YJIT: add comments and assertions to context cache code #10983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
XrXr
reviewed
Jun 12, 2024
maximecb
commented
Jun 12, 2024
maximecb
force-pushed
the
yjit_ctx_cache_1024
branch
from
f407dca
to
f5a1237
Compare
The other day I ran into a mysterious bug while increasing the cache size to 1024. I was not able to reproduce this locally. Opening this PR for testing/debugging.
Co-authored-by: Alan Wu <XrXr@users.noreply.github.com>
maximecb
force-pushed
the
yjit_ctx_cache_1024
branch
from
f5a1237
to
3ee9ccf
Compare
maximecb
force-pushed
the
yjit_ctx_cache_1024
branch
from
90be47f
to
67afd93
Compare
maximecb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other day I ran into a mysterious bug while increasing the cache size to 1024. I was not able to reproduce this locally. Opening this PR for testing/debugging.