Make Resolv::DNS::Name validation similar to host and dig commands. #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0kubun
added a commit
to p1366/ruby
that referenced
this pull request
Aug 17, 2019
k0kubun
added a commit
to p1366/ruby
that referenced
this pull request
Aug 19, 2019
hsbt
force-pushed
the
resolv-domain-name-validation
branch
from
c71e4c3
to
62104c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolv::DNS::Name.create(str)does not make any validation.And it returns false positive results for queries like
Resolv::DNS.new.getresources('.gmail....com', Resolv::DNS::Resource::IN::MX)I added basic RFC validations in
Resolv::DNS::Label.splitto get ArgumentError with messages similar to host and dig commands.