Fix useless operator warnings #1660
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Forwardable._valid_method?` warns about useless operator when it is received an operator such as `*` and `+`.
```bash
$ RUBYOPT='-w' ruby -rforwardable -e 'Forwardable._valid_method?(:*)'
<compiled>: warning: possibly useless use of * in void context
```
This behavior is problematic when a delegator is defined for an operator.
For example:
```ruby
require 'forwardable'
class A
extend Forwardable
def s
's'
end
def_delegator :s, :* # <compiled>: warning: possibly useless use of * in void context
end
p(A.new * 10) # => "ssssssssss"
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwardable._valid_method?warns about useless operator when it is received an operator such as*and+.This behavior is problematic when a delegator is defined for an operator.
For example: