Add #empty? to Tempfile, StringIO, File::Stat #1759
+48
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikegee
force-pushed
the
add-some-empty-checks
branch
from
fc1f398
to
c717414
Compare
|
I couldn't find where to add tests for |
esparta
reviewed
Nov 17, 2017
ext/stringio/stringio.c
Outdated
| rb_raise(rb_eIOError, "not opened"); | ||
| } | ||
| long len = RSTRING_LEN(string); | ||
| if (len == 0) { return Qtrue; } |
There was a problem hiding this comment.
Since len is not used anywhere else but that if, can this be equivalent?
if (RSTRING_LEN(string) == 0) { return Qtrue; }
mikegee
force-pushed
the
add-some-empty-checks
branch
from
c717414
to
7a939cc
Compare
|
Would love to see this merged in the name of 🦆 typing. 🙂 |
|
Same here. |
k0kubun
added a commit
to mikegee/ruby
that referenced
this pull request
Aug 17, 2019
Rubocop prefers `empty?` over `length == 0` and `size == 0`, which is great for String, Array, Hash, etc. It would be nice if more classes implemented `#empty?` for consistancy. See related discussion at rubocop/rubocop#2841
hsbt
force-pushed
the
add-some-empty-checks
branch
from
4ff82b3
to
28fbcde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rubocop prefers
empty?overlength == 0andsize == 0, which is great for String, Array, Hash, etc. It would be nice if more classes implemented#empty?for consistency.See related discussion at rubocop/rubocop#2841
https://bugs.ruby-lang.org/issues/14136