Reduce allocations and retained memory in uri/common.rb #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0kubun
reviewed
Jan 27, 2018
lib/uri/common.rb
Outdated
| end | ||
| TBLENCWWWCOMP_[' '] = '+' | ||
| TBLENCWWWCOMP_[' '] = -'+' |
There was a problem hiding this comment.
Why do you call String#-@ in addition to specifying # frozen_string_literal: true here? The '+' literal should be frozen and de-duplicated without calling it.
|
The failing test should be fixed. |
SamSaffron
force-pushed
the
common-uri
branch
from
384308e
to
0b61c04
Compare
|
OK, made a ticket in redmine here: https://bugs.ruby-lang.org/issues/14410 I think I corrected both issues @k0kubun |
|
merged at 26b3dc4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce allocations in uri/common.rb
Opening a ticket on redmine to discuss