[Docs] Remove outdated example from Numeric documentation #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddor
reviewed
Mar 27, 2018
Since 2.5, Numeric instances can be cloned and duplicated.
nomadium
force-pushed
the
update-numeric-documentation
branch
from
8551efd
to
7bf4c51
Compare
|
@paddor Thanks for the observation. I updated the change accordingly. |
matzbot
pushed a commit
that referenced
this pull request
Jul 30, 2018
Remove outdated example from Numeric documentation Since 2.5, Numeric instances can be cloned and duplicated. [Fix GH-1850] From: Miguel Landaeta <miguel@miguel.cc> git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@64127 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
matzbot
pushed a commit
that referenced
this pull request
Aug 18, 2018
Remove outdated example from Numeric documentation Since 2.5, Numeric instances can be cloned and duplicated. [Fix GH-1850] From: Miguel Landaeta <miguel@miguel.cc> git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@64435 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
While working on implementing some features in JRuby, I just noticed Numeric class documentation [1] has an outdated example. It warns users that Integers can't be duplicated and that is not true since Ruby 2.4. Since 2.5, Numeric instances can be cloned and duplicated as well [2].
Thanks for your feedback.