Expose rb_str_append as String#append and special case BINARY encoded buffers.
#1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
force-pushed
the
string-append
branch
from
dd61df2
to
3251e85
Compare
eregon
reviewed
Aug 27, 2018
| { | ||
| StringValue(str2); | ||
|
|
||
| if (RB_ENCODING_IS_ASCII8BIT(str) || ENCODING_GET(str) == ENCODING_GET(str2)) { |
There was a problem hiding this comment.
That check is too simple, it should be something like "is str encoding's a superset of str2's encoding?".
e.g. it's fine to append US-ASCII to UTF-8.
There was a problem hiding this comment.
Or alternatively make this method only work on binary strings and name it byteappend (see issue).
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see https://bugs.ruby-lang.org/issues/14975 for discussion.