Appveyor MinGW build update #1945
Conversation
|
Please have a look at 7dbdb02 in this PR. The code in r64582 fixed the failures, but I noticed an issue with ruby-loco. The previous code tested for whether the bindir and Ruby's bin dir were the same. This one checks to see if a Ruby executable is in bindir. I tested all three conditionals locally, and all work correctly. Sorry for the mistakes, Greg |
[Fix rubyGH-1945] From: MSP-Greg <MSP-Greg@users.noreply.github.com>
[Fix rubyGH-1945] From: MSP-Greg <MSP-Greg@users.noreply.github.com>
[Fix rubyGH-1945] From: MSP-Greg <MSP-Greg@users.noreply.github.com>
[Fix rubyGH-1945] From: MSP-Greg <MSP-Greg@users.noreply.github.com>
MSP-Greg
force-pushed
the
mingw-build-update
branch
from
a90d43a
to
0796ee1
Compare
|
I'm sorry, I didn't see the activity here. I changed two of the commits and removed the one you added via r64620 c115b39. I revised the ps1 script quite a bit; it's much easier to see the operations it's doing, and the flags are right above. See code here. I think it should build a 32 bit mingw also, but I haven't tried it. I also revised the RubyGems patch, as that failed codeclimate on the first run. I was allowing for some RbConfig keys to be undefined, running tests locally, they were not. The original issue was that the code worked in a normal situation, and it worked with ruby-loco, where, due to old issues, I had my own gem install code. Once MinGW started building here with the normal install code, it broke, That's when I did r64582, but later realized the code was wrong... I often write patches specific to ruby-loco, and especially with tests, and I don't always add conditionals for the platform. I see I did that here also... Sorry. There were some odd things happening, especially when I changed to Finally, some differences I'm seeing between a local and the Appveyor (AV) build. First, revision.h isn't be revised on AV, but is locally. Secondly, the 'cannot' line 744 in the log, and the error after line 784 appear in AV, but not locally. Thanks again for all your work and help, Greg EDIT: Please remove this line in win32/mingw_build_install_64.ps1. |
[Fix rubyGH-1945] From: MSP-Greg <MSP-Greg@users.noreply.github.com>
[Fix rubyGH-1945] From: MSP-Greg <MSP-Greg@users.noreply.github.com>
based on the patch by MSP-Greg at ruby#1945. Co-authored-by: MSP-Greg <greg.mpls@gmail.com>
based on the patch by MSP-Greg at ruby#1945. Co-authored-by: MSP-Greg <greg.mpls@gmail.com>
based on the patch by MSP-Greg at #1945. Co-authored-by: MSP-Greg <greg.mpls@gmail.com> git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64627 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Add a PowerShell script to built & install. Patch up code & tests to pass.
See Ruby Issue 15060