Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: improve error messages #2011

Closed
wants to merge 2 commits into from
Closed

parser: improve error messages #2011

wants to merge 2 commits into from

Conversation

akimd
Copy link

@akimd akimd commented Nov 13, 2018

Dear Ruby maintainers,

I think this commit is fairly straightforward. Actually, it seems so obvious that I must be missing something, otherwise, someone would have already done it.

The point of this commit is to move from error messages such as

/tmp/wrong.rb:1: syntax error, unexpected keyword_end
while end
      ^~~

to

/tmp/wrong.rb:1: syntax error, unexpected end
while end
      ^~~

Cheers!

parse.y Outdated Show resolved Hide resolved
To match the previous commit.
@matzbot matzbot closed this in 87b03e8 Nov 25, 2018
bannable pushed a commit to bannable/ruby that referenced this pull request Dec 10, 2018
[Fix rubyGH-2011]

From: Akim Demaille <akim.demaille@gmail.com>

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65969 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants