Allow Kernel#tap to be invoked with arguments like Kernel#send #2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuber
changed the title
Kernel#tap to be invoked with arguments like Kernel#send
shuber
force-pushed
the
sh/enhance-tap
branch
7 times, most recently
from
0529321
to
4162599
Compare
|
It seems to have a conflict now. Could you rebase this from master? |
Tapping methods without any arguments already has nice shorthand via
`Symbol#to_proc`:
```ruby
object.tap { |o| o.example }
object.tap(&:example)
```
Unfortunately once other arguments are involved we have to switch back
to the longer form:
```ruby
array.merge(other).tap { |a| a.delete(object) }
```
This patch introduces a convenient shorthand for these cases which
behaves similar to `Kernel#send`:
```ruby
array.merge(other).tap(:delete, object)
```
Calling `tap` without any arguments or block still raises
`LocalJumpError`:
```ruby
3.tap #=> LocalJumpError: no block given
```
This also makes the existing shorthand even shorter:
```ruby
object.tap { |o| o.example }
object.tap(&:example)
object.tap(:example)
```
---
Ruby issue: https://bugs.ruby-lang.org/issues/15419
|
@k0kubun rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby issue: https://bugs.ruby-lang.org/issues/15419
Tapping methods without any arguments already has nice shorthand via
Symbol#to_proc:Unfortunately once other arguments are involved we have to switch back to the longer form:
This patch introduces a familiar shorthand for these cases which behaves similar to
Kernel#send:Calling
tapwithout any arguments or block still raisesLocalJumpError:This also makes the existing shorthand even shorter: