Correct failed fix from #2068 #2070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivierlacan
force-pushed
the
array-stlike_lookup_fix
branch
from
4581fb4
to
d681451
Compare
olivierlacan
changed the title
olivierlacan
changed the title
olivierlacan
force-pushed
the
array-stlike_lookup_fix
branch
from
56f32ca
to
5047595
Compare
|
Not sure why the changes from 10d85b1 are not showing up in trunk within the GitHub diff interface. |
My previous attempt to correct ruby#2068 apparently failed and the confusing wording ("instances") was merged into trunk instead. This should address any potential confusion.
olivierlacan
force-pushed
the
array-stlike_lookup_fix
branch
from
5047595
to
c7f69d6
Compare
|
@mame Ok I've fixed the issue with the diff, my branch was visibly missing the trunk commit. Sorry about that. |
|
@mame Could you take a look at this? |
|
This looks good to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mame Looks like my force-push to update the branch before you merged it failed. So this one should address the issues you brought up in #2068.
Apologies for the mistake.