Raise EOF if response body content length is known #2074
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcooper
commented
Jan 22, 2019
joshcooper
force-pushed
the
http_14972
branch
from
ef25c22
to
2ae887e
Compare
|
Per https://tools.ietf.org/html/rfc7230#section-3.4:
|
If response body content length is known, then read the complete response body or raise EOF if it is truncated. [Bug #14972][ruby-core:88324]
joshcooper
added a commit
to joshcooper/puppet-runtime
that referenced
this pull request
Aug 12, 2019
Net::HTTP has a bug where it will silently ignore EOF if it downloads fewer than <Content-Length> bytes[1]. Patch ruby 2.4 and 2.5 on all platforms. This is the same as the upstream PR[2]. [1] https://bugs.ruby-lang.org/issues/14972 [2] ruby/ruby#2074
joshcooper
added a commit
to joshcooper/puppet-runtime
that referenced
this pull request
Aug 13, 2019
Net::HTTP has a bug where it will silently ignore EOF if it downloads fewer than <Content-Length> bytes[1]. Patch ruby 2.4 and 2.5 on all platforms. This is the same as the upstream PR[2]. [1] https://bugs.ruby-lang.org/issues/14972 [2] ruby/ruby#2074
|
The net-http gem now has its own repository, so this should be closed. I added a pull request to that repository that offers a way to support this in a backwards compatible manner, as requested by @nurse: ruby/net-http#15. |
|
Thanks @jeremyevans! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If response body content length is known, then read the complete
response body or raise EOF if it is truncated.
[Bug #14972][ruby-core:88324]