Dump symbols reference to their fstr in ObjectSpace.dump() (Feature #15939) #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
changed the title
|
Now master branch has a required check "check_branch", but I couldn't update your branch to include it. Could you rebase this from master to run it? |
Symbols wether they are dynamic or static do hold a reference
onto their respective string, so it's important to dump these
references so that it's possible to see that a String isn't
garbage collected because it has an associated Symbol.
Dumping a static Symbol:
```
>> puts ObjectSpace.dump(:foobar)
{"address":"0x7a210c", "type":"SYMBOL", "value":"foobar", "references":["0x7f8dd482c7d8"], "dynamic": false}
```
Dumping a dynamic Symbol:
```
>> puts ObjectSpace.dump("foobar".to_sym)
{"address":"0x7fcdf7042eb0", "type":"SYMBOL", "class":"0x7fcdf70c8628", "frozen":true, "bytesize":6, "value":"foobar", "dynamic":true, "references":["0x7fcdf7042ed8"], "memsize":40, "flags":{"wb_protected":true}}
```
Limitations:
`ObjectSpace.dump_all` rely on `rb_objspace_reachable_objects_from` to list an object's references.
Because of this static symbol references are not followed, and
as such are invisible in `ObjectSpace.dump_all`.
I'd like to correct it but it's quite more complicated.
|
I rebased and the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://bugs.ruby-lang.org/issues/15939
Symbols wether they are dynamic or static do hold a reference
onto their respective string, so it's important to dump these
references so that it's possible to see that a String isn't
garbage collected because it has an associated Symbol.
Dumping a static Symbol:
Dumping a dynamic Symbol:
Limitations:
ObjectSpace.dump_allrely onrb_objspace_reachable_objects_fromto list an object's references.Because of this static symbol "references" are not followed, and
as such are invisible in
ObjectSpace.dump_all.I'd like to correct it but it's quite more complicated.