Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win32.c: Remove unused calls to StartSockets #2312

Merged
merged 2 commits into from
Oct 11, 2019

Conversation

GabrielNagy
Copy link
Contributor

@GabrielNagy GabrielNagy commented Aug 1, 2019

NtSocketsInitialized behavior changed in e33b169, requiring a call to rb_w32_sysinit for starting Windows Sockets.

This commit removes NtSocketsInitialized entirely to avoid confusion.

/cc @nobu as the original committer

GabrielNagy and others added 2 commits August 1, 2019 17:11
NtSocketsInitialized behavior changed in e33b169, requiring
a call to rb_w32_sysinit for starting Windows Sockets.

This commit removes NtSocketsInitialized entirely to avoid confusion.

Signed-off-by: Gabriel Nagy <gabriel.nagy@puppet.com>
@shyouhei
Copy link
Member

ping @nobu

@nobu nobu merged commit ddfb306 into ruby:master Oct 11, 2019
@GabrielNagy GabrielNagy deleted the win32-remove-unused-startsockets branch October 11, 2019 05:44
shyouhei added a commit to shyouhei/ruby that referenced this pull request Apr 10, 2020
Every time a pointer to/from VALUE conversion happens, these two
warnings are issued:

- warning ruby#1684: conversion from pointer to same-sized integral type (potential portability problem)
- warning ruby#2312: pointer cast involving 64-bit pointed-to type

Thank you, but we are well aware of the "potential portability problem".
Let us ignore them all.
shyouhei added a commit to shyouhei/ruby that referenced this pull request Apr 10, 2020
Every time a pointer to/from VALUE conversion happens, these two
warnings are issued:

- warning ruby#1684: conversion from pointer to same-sized integral type (potential portability problem)
- warning ruby#2312: pointer cast involving 64-bit pointed-to type

Thank you, but we are well aware of the "potential portability problem".
Let us ignore them all.
shyouhei added a commit to shyouhei/ruby that referenced this pull request Apr 10, 2020
Every time a pointer to/from VALUE conversion happens, these two
warnings are issued:

- warning ruby#1684: conversion from pointer to same-sized integral type (potential portability problem)
- warning ruby#2312: pointer cast involving 64-bit pointed-to type

Thank you, but we are well aware of the "potential portability problem".
Let us ignore them all.
shyouhei added a commit that referenced this pull request Apr 10, 2020
Every time a pointer to/from VALUE conversion happens, these two
warnings are issued:

- warning #1684: conversion from pointer to same-sized integral type (potential portability problem)
- warning #2312: pointer cast involving 64-bit pointed-to type

Thank you, but we are well aware of the "potential portability problem".
Let us ignore them all.
matzbot pushed a commit that referenced this pull request Jul 4, 2020
	configure: suppress icc warnings

	Every time a pointer to/from VALUE conversion happens, these two
	warnings are issued:

	- warning #1684: conversion from pointer to same-sized integral type (potential portability problem)
	- warning #2312: pointer cast involving 64-bit pointed-to type

	Thank you, but we are well aware of the "potential portability problem".
	Let us ignore them all.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants