Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win32.c: Remove unused calls to StartSockets #2312

Merged
merged 2 commits into from Oct 11, 2019

Conversation

@GabrielNagy
Copy link
Contributor

GabrielNagy commented Aug 1, 2019

NtSocketsInitialized behavior changed in e33b169, requiring a call to rb_w32_sysinit for starting Windows Sockets.

This commit removes NtSocketsInitialized entirely to avoid confusion.

/cc @nobu as the original committer

GabrielNagy and others added 2 commits Aug 1, 2019
NtSocketsInitialized behavior changed in e33b169, requiring
a call to rb_w32_sysinit for starting Windows Sockets.

This commit removes NtSocketsInitialized entirely to avoid confusion.

Signed-off-by: Gabriel Nagy <gabriel.nagy@puppet.com>
@shyouhei

This comment has been minimized.

Copy link
Member

shyouhei commented Oct 11, 2019

ping @nobu

@nobu nobu merged commit ddfb306 into ruby:master Oct 11, 2019
10 checks passed
10 checks passed
latest (check)
Details
check_branch
Details
latest (test-bundler)
Details
latest (windows-2016, 2017, test)
Details
latest (test-bundler)
Details
latest (test-bundled-gems)
Details
latest (windows-2019, 2019, test)
Details
latest (test-bundled-gems)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@GabrielNagy GabrielNagy deleted the GabrielNagy:win32-remove-unused-startsockets branch Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.