win32.c: Remove unused calls to StartSockets #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NtSocketsInitialized behavior changed in e33b169, requiring a call to rb_w32_sysinit for starting Windows Sockets. This commit removes NtSocketsInitialized entirely to avoid confusion. Signed-off-by: Gabriel Nagy <gabriel.nagy@puppet.com>
|
ping @nobu |
shyouhei
added a commit
to shyouhei/ruby
that referenced
this pull request
Apr 10, 2020
Every time a pointer to/from VALUE conversion happens, these two warnings are issued: - warning ruby#1684: conversion from pointer to same-sized integral type (potential portability problem) - warning ruby#2312: pointer cast involving 64-bit pointed-to type Thank you, but we are well aware of the "potential portability problem". Let us ignore them all.
shyouhei
added a commit
to shyouhei/ruby
that referenced
this pull request
Apr 10, 2020
Every time a pointer to/from VALUE conversion happens, these two warnings are issued: - warning ruby#1684: conversion from pointer to same-sized integral type (potential portability problem) - warning ruby#2312: pointer cast involving 64-bit pointed-to type Thank you, but we are well aware of the "potential portability problem". Let us ignore them all.
shyouhei
added a commit
to shyouhei/ruby
that referenced
this pull request
Apr 10, 2020
Every time a pointer to/from VALUE conversion happens, these two warnings are issued: - warning ruby#1684: conversion from pointer to same-sized integral type (potential portability problem) - warning ruby#2312: pointer cast involving 64-bit pointed-to type Thank you, but we are well aware of the "potential portability problem". Let us ignore them all.
shyouhei
added a commit
that referenced
this pull request
Apr 10, 2020
Every time a pointer to/from VALUE conversion happens, these two warnings are issued: - warning #1684: conversion from pointer to same-sized integral type (potential portability problem) - warning #2312: pointer cast involving 64-bit pointed-to type Thank you, but we are well aware of the "potential portability problem". Let us ignore them all.
matzbot
pushed a commit
that referenced
this pull request
Jul 4, 2020
configure: suppress icc warnings Every time a pointer to/from VALUE conversion happens, these two warnings are issued: - warning #1684: conversion from pointer to same-sized integral type (potential portability problem) - warning #2312: pointer cast involving 64-bit pointed-to type Thank you, but we are well aware of the "potential portability problem". Let us ignore them all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NtSocketsInitialized behavior changed in e33b169, requiring a call to
rb_w32_sysinitfor starting Windows Sockets.This commit removes
NtSocketsInitializedentirely to avoid confusion./cc @nobu as the original committer