Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import ruby/ruby-signature #2934

Closed
wants to merge 3 commits into from
Closed

Import ruby/ruby-signature #2934

wants to merge 3 commits into from

Conversation

soutaro
Copy link
Member

@soutaro soutaro commented Feb 27, 2020

This PR is to move source code from ruby/ruby-signature to ruby/ruby. Waiting for any suggestion to finish the transition. 馃檹

The expected workflow is the following:

  1. ruby-signature gem is under development for Ruby 2.7.
  2. The gem will release for Ruby 2.7 as an opt-in gem.
  3. The gem will ship with Ruby 2.8/3.0. (No need to gem install with those versions.)
  4. ruby/ruby will be the upstream for the library once this PR get merged.

Questions I have:

  • How can I run tests?
  • How can I run racc for parser.
  • How can I write .gemspec for ruby/ruby repository.

@hsbt
Copy link
Member

hsbt commented Feb 27, 2020

I have the some concerns.

  1. How use test/signature instead of test/ruby-signature? Because the test files for lib/foo are test/foo or test/test_foo.rb in the current structure.
  2. How move sig/test to test/sig?

@k0kubun
Copy link
Member

k0kubun commented Feb 27, 2020

Just curious: Is there any motivation to make this default gems instead of bundled gems?

Default gems are double-master development and hard to sync. Because of the maintenance cost, in general I insist that we should not use default gems unless we need to workaround load issues (rubygems, bundler, and its dependencies).

@soutaro
Copy link
Member Author

soutaro commented Apr 10, 2020

I'm sorry for the late reply. (It was 1.5 months ago. 馃槺)

@hsbt Sounds reasonable. I'll try to move the files.

@k0kubun I don't have strong opinion, and it seems like making RBS a bundled gem makes sense to me. What I don't want is having double-master. I strongly want to have one upstream in ruby repository.

@soutaro soutaro closed this Apr 27, 2020
@soutaro soutaro deleted the rbs branch April 27, 2020 13:13
@soutaro
Copy link
Member Author

soutaro commented Apr 27, 2020

We had talked about this and concluded that ruby-signature repo won't be merged for now. The gem will be ship with Ruby3 as a bundled gem, but the development will continue on ruby/ruby-signature repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants