New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sp calculation #3404
Fix sp calculation #3404
Conversation
Maybe this PR add a pass, right? |
Thank you to review.
Oh, I hadn't considered that.
OK. I'm going to try it later. |
@ko1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed your comment.
Seems ok, could you merge it?
Thank you for your review.
I am beginning to fear that perhaps this PR could have a negative impact on some other environments. |
No, Nothing. |
…unreachable_chunk()` after `iseq_set_sequence()`" This reverts commit 3685ed7 and 5dc107b. Because of some CI failures #3404 (comment).
WARNING: It causes stack underflow on pattern matching without #3403. #3403 is needed before the PR.
In Ruby compile flow,
iseq_peephole_optimize()
is called beforeiseq_set_sequence()
.It can causes "removing dead code", but dead code may use for sp adjusting. (see #3402 #3403)
So I guess that some peephole optimizing should be placed after
iseq_set_sequence()
.