Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comply with guide for method doc: array.c #3506

Merged
merged 2 commits into from Sep 2, 2020
Merged

Comply with guide for method doc: array.c #3506

merged 2 commits into from Sep 2, 2020

Conversation

BurdetteLamar
Copy link
Member

Methods:

  • any?
  • all?
  • one?
  • none?
  • sum
  • shuffle!
  • shuffle
  • sample

@BurdetteLamar BurdetteLamar added the Documentation Improvements to documentation. label Sep 2, 2020
Copy link
Contributor

@jeremyevans jeremyevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have a couple reocmmendations, but they could be done in later commits.

array.c Show resolved Hide resolved
array.rb Outdated Show resolved Hide resolved
@BurdetteLamar BurdetteLamar merged commit 54fb8fb into ruby:master Sep 2, 2020
@mame
Copy link
Member

mame commented Nov 12, 2020

I've added three comments into 54fb8fb.

@mame
Copy link
Member

mame commented Nov 12, 2020

I've a bit changed the rdocs at a02ba60 and a237617, respectviely, for the second comment and for the third one.
I've asked @mrkn, who is the author of Array#sum, to address the first one.

If you don't like our fixes, I'm sorry but let me know. Thanks!

@BurdetteLamar
Copy link
Member Author

@mame, I have moved on from array.c. You can put your changes into a PR if you like.

@BurdetteLamar
Copy link
Member Author

BurdetteLamar commented May 12, 2021

@hsbt, @marcandre, @mame: I don't understand. Am I obliged to respond to comments for an already-merged PR? This PR was approved by @jeremyevans, merged in September, and then commented on in November.

Also, I didn't ignore the comments. I just asked for them to be put into a new PR.

@mame
Copy link
Member

mame commented May 13, 2021

I just wanted to let you know that I partially reverted some of your changes because they were wrong.

I think your answer "I have moved on from array.c." looked not-responsible a little, but I'm okay if you do not make the same mistake again.

@BurdetteLamar
Copy link
Member Author

I just wanted to let you know that I partially reverted some of your changes because they were wrong.

I think your answer "I have moved on from array.c." looked not-responsible a little, but I'm okay if you do not make the same mistake again.

Sorry, I completely misunderstood the issues here, and am not sure I understand them now. Is there anything I need to do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements to documentation.
3 participants