[Bug #17192] raise when loading builtin function #3622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobu
force-pushed
the
bug/17192-loading-builtin-function
branch
2 times, most recently
from
63a6bcf
to
dc1ff63
Compare
nevans
pushed a commit
to nevans/ruby
that referenced
this pull request
Nov 14, 2020
* 0.1s is really short and fails in CI: ruby#3622 rubygems/rubygems@d8495ae1c1
jeremyevans
reviewed
Nov 24, 2020
test/ruby/test_iseq.rb
Outdated
| f.write(RubyVM::InstructionSequence.of(1.method(:abs)).to_binary) | ||
| f.close | ||
| assert_normal_exit("#{<<~"begin;"}\n#{<<~'end;'}") | ||
| path = ""#{f.path.dump} |
There was a problem hiding this comment.
The ""#{f.path.dump} part seems odd to me. It also seems odd this checks for a normal exit, when the use of a builtin function inside an iseq should raise an ArgumentError when loading. Maybe we want something like this:
+ assert_raise(ArgumentError) do
+ RubyVM::InstructionSequence.load_from_binary(File.binread(f.path))
+ endOf if we do want to use a separate process, check that it produces an error instead of exits normally?
The compile.c changes do look correct and I tested that the patch does fix the crash.
There was a problem hiding this comment.
""#{f.path.dump} is to tell ruby-mode.el that the rest is not in the string literal.
nobu
force-pushed
the
bug/17192-loading-builtin-function
branch
from
dc1ff63
to
a74b2a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.