Fix calling enumerator methods such as with_index on Enumerator::Chain #3811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeremyevans patch looks good. Maybe just missing a test to insure the Anything else holding it up? |
|
Nothing holding it up as far as I know. I'm not sure I'll be able to work more on this before the release of 3.0, but feel free to merge and add a test for the lazy case before release if you want. |
This previously raised a TypeError. Wrap the Enumerator::Chain in an Enumerator to work around the problem. Fixes [Bug #17216]
…r is lazy Implements [Feature #17347]
Previously these methods were defined but raised TypeError, which seems worse.
jeremyevans
force-pushed
the
fix-enum-chain-enum-methods-17216
branch
from
b7754c5
to
001e98d
Compare
marcandre
approved these changes
Mar 6, 2021
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This previously raised a TypeError. Wrap the Enumerator::Chain in
an Enumerator to work around the problem.
Fixes [Bug #17216]