Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenStruct's exception, special-string, Enumerator#size #383

Closed
wants to merge 4 commits into from
Closed

OpenStruct's exception, special-string, Enumerator#size #383

wants to merge 4 commits into from

Conversation

kachick
Copy link
Member

@kachick kachick commented Aug 17, 2013

No description provided.

@kachick
lib/ostruct.rb: Update exception class
78592c7 
* lib/ostruct.rb (OpenStruct#modifiable): Builtin classies raises
  RuntimeError on frozen instance. TypeError is an old way.

* test/ostruct/test_ostruct.rb: Added tests for above.
@kachick
lib/ostruct.rb: Standardize to use name class
0a5a4d7 
* lib/ostruct.rb (OpenStruct#delete_field): Use Symbol instead of
  String. Not only adjusting style. Some special string behave
  `string.to_sym.to_s != string`.

* test/ostruct/test_ostruct.rb: Added tests for above.
@kachick
lib/ostruct.rb: Enumerator should deal size
c033d03 
* lib/ostruct.rb (OpenStruct#each_pair): Currently, Enumerator has
  size. And Struct#each_pair keeps members-size.

* test/ostruct/test_ostruct.rb: Added tests for above.
@kachick
lib/ostruct.rb: Add #name and #args on NoMethodError
532c3f5 
* lib/ostruct.rb (OpenStruct#method_missing): NoMethodError
  should have #name and #args.

* test/ostruct/test_ostruct.rb: Added tests for above.
@ghost ghost assigned marcandre Oct 15, 2013
@zzak
Copy link
Member

zzak commented Oct 15, 2013

@marcandre Could you review this when you get a chance?

@marcandre
Copy link
Member

These look really good :+1
I'll triple check and commit them soon.

@marcandre marcandre closed this in b9e18ab Oct 23, 2013
marcandre added a commit that referenced this pull request Oct 23, 2013
@marcandre
* lib/ostruct.rb (OpenStruct#delete): Use the converted argument.
99d5d90 
  Patch by Kenichi Kamiya. [Fixes GH-383]

* test/ostruct/test_ostruct.rb: Added tests for above.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43403 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
marcandre added a commit that referenced this pull request Oct 23, 2013
@marcandre
* lib/ostruct.rb (Struct#each_pair): Return an enumerator with size
5b5de39 
  Patch by Kenichi Kamiya. [Fixes GH-383]

* test/ostruct/test_ostruct.rb: Added tests for above.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43404 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
marcandre added a commit that referenced this pull request Oct 23, 2013
@marcandre
* lib/ostruct.rb: raise NoMethodError with a #name and #args.
f9a169f 
  Patch by Kenichi Kamiya. [Fixes GH-383]

* test/ostruct/test_ostruct.rb: Added tests for above.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43405 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@marcandre
Copy link
Member

These were all great commits. They were committed almost verbatim; I tweaked a bit the commit messages.

There was one test that relied on "+(binary)".to_sym == :+. I didn't know that, thanks! I find it a bit crazy. It will probably make it in my RubyConf talk in a few weeks :-) Anyways, I preferred using a test with a general object that converts to a symbol. I also opened http://bugs.ruby-lang.org/issues/9048

@kachick
Copy link
Member Author

kachick commented Oct 23, 2013

Thanks!
I'm looking forward to your talk :)

@kachick kachick deleted the improve-ostruct branch October 23, 2013 17:05
mmasaki pushed a commit to mmasaki/ruby that referenced this pull request Oct 24, 2013
@marcandre
* lib/ostruct.rb: Raise RuntimeError when modifying frozen instances
23ae48e 
  instead of TypeError. Patch by Kenichi Kamiya. [Fixes rubyGH-383]

* test/ostruct/test_ostruct.rb: Added tests for above.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43402 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
mmasaki pushed a commit to mmasaki/ruby that referenced this pull request Oct 24, 2013
@marcandre
* lib/ostruct.rb (OpenStruct#delete): Use the converted argument.
32c8124 
  Patch by Kenichi Kamiya. [Fixes rubyGH-383]

* test/ostruct/test_ostruct.rb: Added tests for above.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43403 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
mmasaki pushed a commit to mmasaki/ruby that referenced this pull request Oct 24, 2013
@marcandre
* lib/ostruct.rb (Struct#each_pair): Return an enumerator with size
48dc1af 
  Patch by Kenichi Kamiya. [Fixes rubyGH-383]

* test/ostruct/test_ostruct.rb: Added tests for above.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43404 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
mmasaki pushed a commit to mmasaki/ruby that referenced this pull request Oct 24, 2013
@marcandre
* lib/ostruct.rb: raise NoMethodError with a #name and #args.
e64315d 
  Patch by Kenichi Kamiya. [Fixes rubyGH-383]

* test/ostruct/test_ostruct.rb: Added tests for above.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43405 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kachick added a commit to kachick/rubinius that referenced this pull request Nov 15, 2013
@kachick
Update a String#{to_sym,intern} spec for "+,-"
d2fad0e 
Follow ticket-9048
See below links

* http://bugs.ruby-lang.org/issues/9048
* ruby/ruby#383 (comment)
kachick added a commit to kachick/rubinius that referenced this pull request Nov 15, 2013
@kachick
Update a String#{to_sym,intern} spec for "+,-"
9dc069c 
Follow ticket-9048
See below links

* http://bugs.ruby-lang.org/issues/9048
* ruby/ruby#383 (comment)
tenderlove pushed a commit to tenderlove/ruby that referenced this pull request Jan 24, 2014
@marcandre
* lib/ostruct.rb: Raise RuntimeError when modifying frozen instances
8f7ef56 
  instead of TypeError. Patch by Kenichi Kamiya. [Fixes rubyGH-383]

* test/ostruct/test_ostruct.rb: Added tests for above.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43402 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
tenderlove pushed a commit to tenderlove/ruby that referenced this pull request Jan 24, 2014
@marcandre
* lib/ostruct.rb (OpenStruct#delete): Use the converted argument.
1f858b2 
  Patch by Kenichi Kamiya. [Fixes rubyGH-383]

* test/ostruct/test_ostruct.rb: Added tests for above.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43403 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
tenderlove pushed a commit to tenderlove/ruby that referenced this pull request Jan 24, 2014
@marcandre
* lib/ostruct.rb (Struct#each_pair): Return an enumerator with size
7e712cd 
  Patch by Kenichi Kamiya. [Fixes rubyGH-383]

* test/ostruct/test_ostruct.rb: Added tests for above.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43404 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
tenderlove pushed a commit to tenderlove/ruby that referenced this pull request Jan 24, 2014
@marcandre
* lib/ostruct.rb: raise NoMethodError with a #name and #args.
347f190 
  Patch by Kenichi Kamiya. [Fixes rubyGH-383]

* test/ostruct/test_ostruct.rb: Added tests for above.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43405 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kddnewton added a commit to kddnewton/ruby that referenced this pull request Aug 10, 2022
@kddnewton
Fix tests on yjit_backend_ir for AArch64 backend (ruby#383)
97991fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marcandre marcandre

Labels
None yet
Milestone
No milestone
3 participants
@kachick @zzak @marcandre