Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to declare visibility of attributes defined by attr* methods in a single expression - v2 #3935

Conversation

radarek
Copy link
Contributor

@radarek radarek commented Dec 18, 2020

Continuation of #3757. I will push each change as a separate commit to check which one fails on CI.
Please, do not merge this PR yet.

@mame mame merged commit 5944c4b into ruby:master Dec 18, 2020
@mame
Copy link
Member

mame commented Dec 18, 2020

Ah, I'm sorry! I overlooked "do not merge."

@radarek
Copy link
Contributor Author

radarek commented Dec 18, 2020

@mame It happens. I created one more (hope it's the last one :D) PR: #3937.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants