-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test/test_trick.rb: Add a test file for TRICK entries #3988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobu
reviewed
Dec 24, 2020
Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
nobu
reviewed
Dec 24, 2020
# Feel free to comment them out if they bother you. | ||
# I'll appreciate it if you could notify mame <mame@ruby-lang.org> | ||
|
||
class TestTRICK2013 < Test::Unit::TestCase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
class TestTRICK2013 < Test::Unit::TestCase | |
class TestTRICK < Test::Unit::TestCase | |
def assert_in_out_err(args, ...) | |
super(%w"-W0" + args, ...) | |
end | |
end | |
class TestTRICK2013 < TestTRICK |
nobu
reviewed
Dec 24, 2020
end | ||
end | ||
|
||
class TestTRICK2015 < Test::Unit::TestCase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
class TestTRICK2015 < Test::Unit::TestCase | |
class TestTRICK2015 < TestTRICK |
nobu
reviewed
Dec 24, 2020
end | ||
end | ||
|
||
class TestTRICK2018 < Test::Unit::TestCase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
class TestTRICK2018 < Test::Unit::TestCase | |
class TestTRICK2018 < TestTRICK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll merge this after Ruby 3.0.0 is released