random generator update for Mac proposal #4081
Conversation
aclocal.m4
Outdated
| @@ -43,6 +43,5 @@ m4_include([tool/m4/ruby_stack_grow_direction.m4]) | |||
| m4_include([tool/m4/ruby_try_cflags.m4]) | |||
| m4_include([tool/m4/ruby_try_cxxflags.m4]) | |||
| m4_include([tool/m4/ruby_try_ldflags.m4]) | |||
| m4_include([tool/m4/ruby_type_attribute.m4]) | |||
There was a problem hiding this comment.
Tell us the reason for this removal?
There was a problem hiding this comment.
Unexpected change, I ll roll it back.
| # if defined(__ANDROID__) || defined(__APPLE__) | ||
| # include <sys/random.h> | ||
| # endif | ||
| # define MAX_SEED_LEN_PER_READ 256 |
There was a problem hiding this comment.
Why is the reason behind this 256?
There was a problem hiding this comment.
It s to avoid EIO errno case since getentropy can handle 256 bytes maximum per call.
There was a problem hiding this comment.
The length is described in the man-pages, but no symbol seems defined for it.
macOS:
The maximum buffer size permitted is 256 bytes. If buflen exceeds this, an error of EIO will be indicated.
Linux:
The maximum permitted value for the length argument is 256.
devnexen
force-pushed
the
random_getentropy
branch
from
6756da6
to
4e40e46
Compare
random.c
Outdated
| # if defined(__ANDROID__) || defined(__APPLE__) | ||
| # include <sys/random.h> | ||
| # endif |
There was a problem hiding this comment.
There is the code for <sys/random.h> already, this should be there too.
That is, at line 52,
#if defined HAVE_GETRANDOM || defined HAVE_GETENTROPY
There was a problem hiding this comment.
I just checked if I remove this line it fails to compile
There was a problem hiding this comment.
It means to add || defined HAVE_GETENTROPY to line 52.
random.c
Outdated
| @@ -497,7 +516,8 @@ fill_random_bytes_syscall(void *buf, size_t size, int unused) | |||
| { | |||
| #if (defined(__OpenBSD__) && OpenBSD >= 201411) || \ | |||
| (defined(__NetBSD__) && __NetBSD_Version__ >= 700000000) || \ | |||
| (defined(__FreeBSD__) && __FreeBSD_version >= 1200079) | |||
| (defined(__FreeBSD__) && __FreeBSD_version >= 1200079) || \ | |||
| defined(__APPLE__) | |||
There was a problem hiding this comment.
Maybe not ... too much randomness at a time in this case indeed :)
There was a problem hiding this comment.
If this condition is enabled, this fill_random_bytes_syscall() never fails and fill_random_bytes_urandom() using getentropy() is never used.
There was a problem hiding this comment.
true I removed it in the last commit anyway.
devnexen
force-pushed
the
random_getentropy
branch
from
4e40e46
to
ea409d1
Compare
using getentropy for seeding, reading 256 bytes at a time to avoid the EIO errno since this is the maximum.
devnexen
force-pushed
the
random_getentropy
branch
from
ea409d1
to
a411d1c
Compare
|
I guess this change broke OpenBSD build: http://rubyci.s3.amazonaws.com/openbsd-current/ruby-master/log/20210118T023008Z.fail.html.gz |
No description provided.