net/http: No need to use a Windows-31J encoded regexp to strip the Host #4286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you send this to https://github.com/ruby/net-http? |
|
Ah damn, I always forget some of the stdlibs have their own repo. |
|
The intention looks |
|
Closing in favor of ruby/net-http#18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this regexp because of the crash reported in #4119 (comment)
It was introduced by @nurse in c1652035644, but I don't see any reason to set a
Windows-31Jencoding on this regexp.It's probably not a big deal, but I'm thinking we might as well use a default
US-ASCII.cc @XrXr @tenderlove