Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix a typo around Hash#compare_by_identity #4303

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

kachick
Copy link
Member

@kachick kachick commented Mar 21, 2021

I don't have confident this is a typo or intentional one.

The Hash#compare_by_identity looks defined as rb_hash_compare_by_id in implementation. If this wording described the implementation, this is not a typo 🙇

ruby/hash.c

Line 4382 in d36ac28

rb_hash_compare_by_id(VALUE hash)

@marcandre marcandre merged commit 5b272a6 into ruby:master Mar 22, 2021
@marcandre
Copy link
Member

Good catch, thanks.

@kachick
Copy link
Member Author

kachick commented Mar 22, 2021

Thanks for your confirmation 🙏

@kachick kachick deleted the fix-doc-typo-in-hash branch March 22, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants