Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Force recycle intermediate collection in Hash#transform_keys!" #4341

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

kachick
Copy link
Member

@kachick kachick commented Mar 31, 2021

Reverts #4329

#4329 (comment)

Please Do not use force_recycle because it is an exceptional operation and slow, now a day . It can violate GC assumptions. I wanted to make it no-op, but I couldn't make it because some code depends on this behavior.

@ko1 🙏 Please merge if it is needed... 🙇

@hsbt
Copy link
Member

hsbt commented Aug 31, 2021

@ko1 How about this?

@ko1 ko1 merged commit bb84c75 into ruby:master Sep 14, 2021
@kachick
Copy link
Member Author

kachick commented May 21, 2022

Thank you!

(https://bugs.ruby-lang.org/issues/18065 looks happened until a part of this code is merged...
e5dd40b 🙇‍♂️ )

@kachick kachick deleted the revert-4329-tmp-hash-force-gc branch May 21, 2022 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants