skip marking for uninitialized imemo_env. #4342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RUBY_INTERNAL_EVENT_NEWOBJ can expose uninitialized imemo_env objects and marking it will cause critical error. This patch skips marking on uninitialized imemo_env. See: http://rubyci.s3.amazonaws.com/centos7/ruby-master/log/20210329T183003Z.fail.html.gz Shortest repro-code is provided by mame-san.
nobu
reviewed
Mar 31, 2021
Comment on lines
+247
to
+256
| prev = GC.stress | ||
| GC.stress = true | ||
|
|
||
| ObjectSpace.trace_object_allocations{ | ||
| proc{} | ||
| } | ||
|
|
||
| assert true # success | ||
| ensure | ||
| GC.stress = prev |
There was a problem hiding this comment.
Suggested change
| prev = GC.stress | |
| GC.stress = true | |
| ObjectSpace.trace_object_allocations{ | |
| proc{} | |
| } | |
| assert true # success | |
| ensure | |
| GC.stress = prev | |
| EnvUtil.under_gc_stress do | |
| ObjectSpace.trace_object_allocations{ | |
| proc{} | |
| } | |
| end |
nobu
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUBY_INTERNAL_EVENT_NEWOBJ can expose uninitialized imemo_env
objects and marking it will cause critical error. This patch
skips marking on uninitialized imemo_env.
See: http://rubyci.s3.amazonaws.com/centos7/ruby-master/log/20210329T183003Z.fail.html.gz
Shortest repro-code is provided by mame-san.