Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tool/ci_functions.sh: Fix typos and improve the comment. [ci skip] #4541

Merged
merged 1 commit into from
May 31, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tool/ci_functions.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
# See `ruby tool/test/runner.rb --help` `-n` option.
function ci_to_excluded_test_opts {
local tests_str="${1}"
# Use the backward matching `!/name$/`, as the perfect matching does not work.
# Use the backward matching `!/name$/`, as the perfect matching doesn't work.
# https://bugs.ruby-lang.org/issues/16936
ruby <<EOF
opts = "${tests_str}".split.map { |test| "-n \!/#{test}\$$/" }
Expand All @@ -16,7 +16,7 @@ EOF
return 0
}

# Create options with patterns `-n /name1/ -n /name2/ ..` to exclude the test
# Create options with patterns `-n name1 -n name2 ..` to include the test
# method names by the method names `name1 name2 ..`.
# See `ruby tool/test/runner.rb --help` `-n` option.
function ci_to_included_test_opts {
Expand Down