Add gvl and fiber assertions to scheduler interface to catch invalid usage. #4656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyevans
reviewed
Jul 16, 2021
ioquatix
force-pushed
the
scheduler-assertions
branch
2 times, most recently
from
567735e
to
860c795
Compare
ioquatix
force-pushed
the
scheduler-assertions
branch
2 times, most recently
from
47561e7
to
25dd891
Compare
eregon
reviewed
Jul 16, 2021
| @@ -639,6 +639,8 @@ rb_check_funcall(VALUE recv, ID mid, int argc, const VALUE *argv) | |||
| static VALUE | |||
| rb_check_funcall_default_kw(VALUE recv, ID mid, int argc, const VALUE *argv, VALUE def, int kw_splat) | |||
| { | |||
| VM_ASSERT(ruby_thread_has_gvl_p()); | |||
There was a problem hiding this comment.
VM_ASSERT is only if VM_CHECK_MODE > 0 so if -DRUBY_DEBUG, so not in regular builds.
Sounds fine to me.
ioquatix
force-pushed
the
scheduler-assertions
branch
from
25dd891
to
75035b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to diagnose/catch the following error reported by @jeremyevans: https://github.com/ruby/ruby/pull/4616/checks?check_run_id=3078517784#step:15:27