.github/workflows/compilers.yml: clang-14 #4718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems LLVM-14 begun. See also llvm/llvm-project@08c766a
|
Let me review. |
junaruga
approved these changes
Aug 9, 2021
There was a problem hiding this comment.
I reviewed. It looks good to me. Thanks!
I checked the following things and the modification of this PR.
- Checked clang-14 deb package is available at
https://apt.llvm.org/focal/dists/llvm-toolchain-focal/main/binary-amd64/Packages . - Checked the clang-14 published pipeline here on ruby/ruby-ci-image repo.
https://github.com/ruby/ruby-ci-image/runs/3272689418?check_suite_focus=true - Checked clang-14 tagged container here.
https://github.com/ruby/ruby-ci-image/pkgs/container/ruby-ci-image/versions - Checked clang-14 used explicitly in the clang-14 case:
https://github.com/ruby/ruby/pull/4718/checks?check_run_id=3272751831 - Checked clang-14 used as a default container in Compilations - NDEBUG case:
https://github.com/ruby/ruby/pull/4718/checks?check_run_id=3272752420
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems LLVM-14 begun: llvm/llvm-project@08c766a
Add CI matrix for that.