Silence LoadError only if it is for rubygems
itself
#4719
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
#2764 attempted to prevent raising
LoadError
when requiringrubygems
because it might not be available optionally when Ruby is delivered via packaging systems and instead prints a warning message.Context
I was working on a feature in RubyGems to better communicate to users that something went wrong when loading
rubygems/defaults/operating_system
and after writing a test, I saw that anyLoadError
exception raised by therubygems
will be captured and a warning will be printed instead (rubygems/rubygems#4824). Although #2764 intention was to prevent failure when 'rubygems' are not available, it's capturing everyLoadError
that might happen inside therubygems
at runtime.Change
Prevent raising the
LoadError
exception only if it's related directly to loadingrubygems
.