Extended logging for debugging readline failures. #4722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
commented
Aug 9, 2021
| @@ -496,7 +496,8 @@ def test_interrupt_in_other_thread | |||
| begin | |||
| Thread.new{ | |||
| trap(:INT) { | |||
| p :INT | |||
| puts 'TRAP' | |||
| $stdout.flush | |||
There was a problem hiding this comment.
@aycabta I wonder if there is some problem here. I noticed that #flush was necessary to make it pass locally. I wonder if this is part of the problem we are seeing on Readline 7.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.