Add Windows Server 2022 with Visual Studio 2022 #4775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znz
force-pushed
the
github-actions-windows-2022
branch
5 times, most recently
from
9dcdb6c
to
3747c6a
Compare
znz
force-pushed
the
github-actions-windows-2022
branch
2 times, most recently
from
acb9cb0
to
890114b
Compare
nobu
reviewed
Aug 25, 2021
Comment on lines
+27
to
+29
| echo VCVARS="C:\Program Files\Microsoft Visual Studio\2022\Preview\VC\Auxiliary\Build\vcvars64.bat" >> %GITHUB_ENV% | ||
| ) ELSE IF ${{ matrix.os }}==windows-2019 ( | ||
| echo VCVARS="C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvars64.bat" >> %GITHUB_ENV% |
There was a problem hiding this comment.
This makes %VCVARS% to include double quotes.
It feels weird a little.
There was a problem hiding this comment.
PATH without double quotes causes an error.
So I add double quotes to echo again, and remove from call.
https://github.com/ruby/ruby/runs/3418598073?check_suite_focus=true#step:4:11
Run IF windows-2022==windows-2022 (
IF windows-2022==windows-2022 (
echo VCVARS=C:\Program Files\Microsoft Visual Studio\2022\Preview\VC\Auxiliary\Build\vcvars64.bat >> %GITHUB_ENV%
) ELSE IF windows-2022==windows-2019 (
echo VCVARS=C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvars64.bat >> %GITHUB_ENV%
)
shell: C:\Windows\system32\cmd.EXE /D /E:ON /V:OFF /S /C "CALL "{0}""
env:
GITPULLOPTIONS: --no-tags origin refs/pull/4775/merge
PATCH: C:\msys64\usr\bin\patch.exe
\Microsoft was unexpected at this time.
Error: Process completed with exit code 255.
402a314
to
8644262
Compare
Because patch does not installed on windows-2022. actions/runner-images#3949 > Only pure MSYS2 is installed. No additional packages
znz
force-pushed
the
github-actions-windows-2022
branch
from
2b43c2a
to
019e476
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.blog/changelog/2021-08-23-github-actions-windows-server-2022-with-visual-studio-2022-is-now-available-on-github-hosted-runners-public-beta/