Update rubygems and bundler with master branch #4789

rubygems/rubygems@a669401a5a

This error can only be raised when loading the cache, and we only load the cache if this condition is met. rubygems/rubygems@86d692edb8

rubygems/rubygems@310937a546

rubygems/rubygems@c7e3c092e1

…installing it Not only the first one that's missing. This also allows us to simplify things. rubygems/rubygems@69718a9509

If we have succeeded to materialize the bundle, all specs should be loaded. rubygems/rubygems@bd3712d824

Bundler formatters already take care of this. rubygems/rubygems@c24415fdd5

…ails rubygems/rubygems@98f5087e34

These gems are built and installed to system directly as default gems. There's no need to also build a remote repo. rubygems/rubygems@ad9dad4c22

TSort was released as a library so we can install it, and also other gems that are loaded by the spec. Also, Ruby on Windows apparently loads fiddle 1.0.6, so we need to also install that to make that not fail. rubygems/rubygems@2b8dcab99e

Rubygems source replacement was broken. rubygems/rubygems@3549c122f6

…ource compatibility mode Since this mode is only enabled in frozen mode, it's fine to use the lockfile and means we don't have to "prepare" the replacement for materialization. rubygems/rubygems@dda01b288e

No need to fill up missing names from sources anymore since they should now be properly set up correctly from the beginning. rubygems/rubygems@706fd28681

rubygems/rubygems@f28ab141af

This should fix a weird flaky spec failure, given that the code producing the error will be no longer run. rubygems/rubygems@a171965409

…lone script Due to the `bundler` gem itself being ignored from `$LOAD_PATHS`, a `nil` value is being introduced here, resulting in the current folder being added to the `$LOAD_PATH` by the standalone script. I'm pretty sure this is unintentional. rubygems/rubygems@df54b07b5e

We can use `__dir__` directly. rubygems/rubygems@0e6083ca94

Under some case, this variable might not end up being used, in which case running the script would print unused variable warnings. rubygems/rubygems@a2d6392ada

… script rubygems/rubygems@fcb8c3d188

Under some case, this variable might not end up being used, in which case running the script would print unused variable warnings. rubygems/rubygems@bf96030362

… sources In the case of path sources, the path the source is pointing to should be added directly to the `$LOAD_PATH` without any modifications. rubygems/rubygems@d3bba936f0 Co-authored-by: Daniel Niknam <mhmd.niknam@gmail.com>

It doesn't really add much, in my opinion. We want to be helpful, but also concise when possible. rubygems/rubygems@9d56009cf7

Since all requirements have an explicit source now (even if it's the default source). rubygems/rubygems@2c341cfc22

rubygems/rubygems@9fd39bd5a3

When printing sources inside these error messages, it's useful to only consider the current state of the source. For example, when requiring `bundler/setup`, the source shouldn't be configured to be able to hit the network, so the error message should only mention "locally installed gems" to make that more clear. rubygems/rubygems@30eb14f853

…e network rubygems/rubygems@06f5efce02

…hit the network If the cache was missing, `bundler` would try to re-fetch it. With the `--local` flag, it should just look at installed gems. rubygems/rubygems@630d29c69e

rubygems/rubygems@d74830d00b

… between sentence breaks rubygems/rubygems@5cdda53382

The processed YML data is included as metadata, the source gemspec file is unused and just confusing. rubygems/rubygems@f444478eac

rubygems/rubygems@88b7a3e7e2

rubygems/rubygems@ed845d861c

rubygems/rubygems@591466d512

rubygems/rubygems@36a00144b9

rubygems/rubygems@c7c00c280f

The commented out code causes failing tests because it's not correct. rubygems/rubygems@38f0eca91a

When I read, I thought the assertion was incorrect. It's doing the right thing, though. rubygems/rubygems@e72c27367a

rubygems/rubygems@a2d6e10192

rubygems/rubygems@c31b8cd232

The previous behavior was to automatically require `bundler/setup` everytime `rubygems` was required, which I think was too much. rubygems/rubygems@b25379a295

Instead of having to match classes and re-raise in the exception body. rubygems/rubygems@5edf74b781

As far as I understand, this block should only be run when `bundler/setup` fails. The only other case where these errors could be run is when bundler itself is required. If bundler itself fails to be required or activated (like in old rubies where it was not a default gem, for example), the raw error is much more helpful than this message. So we can move the rescue after bundler is succesfully required, and that simplifies the list of exceptions that we need to track to just `Bundler::Error`. rubygems/rubygems@3663c11e93

rubygems/rubygems@320fdc1513

…nerated config Otherwise CI will run once for every pull request update and once for every push. The disavantage is that people working on a non default branch without creating pull requests won't get CI run at all. I think the advantages are greater than the disadvantages, it's also my personal workflow, and it's something desired enough so that someone opened an issue about it. So let's do it! rubygems/rubygems@924d916a73 Co-authored-by: NeimadTL <damientalbot26@gmail.com>

…ons generated config Even if it only has one entry at the moment, it makes it easier to add new entries by doing it this way. rubygems/rubygems@46232fe265 Co-authored-by: NeimadTL <damientalbot26@gmail.com>

rubygems/rubygems@91dca11112

…ll -g` rubygems/rubygems@4028cbc408

Given Windows doesn't have executable bit. rubygems/rubygems@35dc3fa845

When setting the `RUBYGEMS_GEMDEPS` environment variable to allow skipping `bundle exec`, `bundler` will print a warning about potential incompatibility. Initially the `RUBYGEMS_GEMDEPS` variable used a completely different (re)implementation of `bundler` functionality. That implementation was not battle tested and could potentially differ in behaviour from what `bundler` does. That's why print a warning. However, these days, all `rubygems` does when `RUBYGEMS_GEMDEPS` is set is to require `bundler/setup`, so there's no risk of any incompatibility, since that's just plain `bundler`. rubygems/rubygems@bbddc27016

Running `bundler` specs using `bundler` is not supported. rubygems/rubygems@cc97b6773d

…tion rubygems/rubygems@58fc31442f

rubygems/rubygems@82960c262f

…defaults/operating_system file When loading `rubygems/defaults/operating_system` - we want to keep it silent if the raised exception is a LoadError - we want to print a message in other cases and ask users to report the issue to their OS support. Ruby 3 comes with special error handling for loading `rubygems` and it will show a warning when LoadError exception raised for requiring 'rubygem'. Because of that, we decided to leave the LoadError scenario as it is. Reference: https://github.com/ruby/ruby/blob/d1998d8767affe58be0bd09ec536dae9198a7fbd/gem_prelude.rb#L1-L5 rubygems/rubygems@0a97e12fe1

…operating_system.rb truffleruby does not raise any error when requiring `rubygems`. rubygems/rubygems@21e2fcd0b2

…ter now rubygems/rubygems@0822e1c260

rubygems/rubygems@58da501e5d

For errors that could happened while loading `rubygems/defaults/operating_system` rubygems/rubygems@6e1e2141f8

We think it's unlikely that `rubygems/defaults/operating_system` could be shipped with a SyntaxError so StandardError could be better choice to prevent "false positives" errors. rubygems/rubygems@1f73e784dd

MacOS should properly configure Ruby. They should not expect us to maintain a different layout just for them. rubygems/rubygems@ecad900925

They should properly configure `GEM_PATH` instead. rubygems/rubygems@3bd9ae33ca

rubygems/rubygems@81dc685d20

No longer used since rubygems/rubygems@b7f6270. rubygems/rubygems@76803894a0

Use the `git branch --list` rather than the `git branch -l` for better compatibility. Because the `git branch -l` is used to create a new branch in Git version < 2.20.0. rubygems/rubygems@eac5be7d06

As part of a recent bug fix where bundler was accidentally hitting the network when not supposed to, I made some refactoring, and the commit I'm reverting here (rubygems/rubygems@d74830d) was some cleanup that those refactorings allowed according to "past me". That was completely wrong, `bundle check` should never consider cached gems, only installed gems, so the code that was removed was necessary. rubygems/rubygems@5483e98305

…ng local mode rubygems/rubygems@1b8139e9d3

If the lockfile contains multiple platforms, `bundle check` would show duplicated missing gems. rubygems/rubygems@6ac5931783

…al requires rubygems/rubygems@c74fc58695

rubygems/rubygems@e3d150d822 Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>

…own method The `Gem::Platform::RUBY ? -1 : 1` has been used multiple times in different places and could be refactored to a method (DRY). rubygems/rubygems@9d43ca8f0c

…asic rubygems/rubygems@290b6ab078

rubygems/rubygems@9620bee2a5

The error had not be caught be specs because `bundle install` was returning a zero exit code when plugin installation errors happened. So I fixed that issue too. rubygems/rubygems@90cde87856

rubygems/rubygems@a7023c6c21

rubygems/rubygems@986e889a79

rubygems/rubygems@4188ebd568

rubygems/rubygems@a296052670

…lace Since it clears both home and path. rubygems/rubygems@fadf5e03ea

…lled versions rubygems/rubygems@9c88db949d

…y two values returned rubygems/rubygems@601b5553bb

rubygems/rubygems@1ea73df161

…RIs to be used on outputs We need to redact URI credential in several places and copy pasting the code into each part of it is not ideal. This class is responsible for parsing URI strings and redacting credential from it. Also, it will handle URI object in the same manner. We will be reusing this class whenever we need to print/display a URI to users. URI with the following format will be redacted: - Token: `http://my-secure-token@example.com` => `http://REDACTED@example.com` - Username & Password: `http://my-username:my-secure-password@example.com` => `http://my-username:REDACTED@example.com` - x-oauth-basic: `http://my-secure-token:x-oauth-basic@example.com` => `http://REDACTED:x-oauth-basic@example.com` rubygems/rubygems@f1e45d3a89

…allCommand` class The `x.source.uri` could be a source URI with a credential. Using `Gem::PrintableUri` to make sure we are redacting sensitive information from it. rubygems/rubygems@8755ee0aaa

The `@uri` variable could be a source URI with a credential. Using `Gem::PrintableUri` to make sure we are redacting sensitive information from it when logging on verbose mode. rubygems/rubygems@f566787211

…izer to `build` method The `initialize` method is already doing a lot and by adding the `Gem::PrintableUri` to redact sensitive information, things are getting complicated and hard to read here. For the start, I have refactored the `initialize` method into a class method called `build`. rubygems/rubygems@4312e8fdf5

rubygems/rubygems@5b6b649bba

…rintableUri#valid_uri?` rubygems/rubygems@a5177709c9

rubygems/rubygems@dba130cd80

…ack to its initialize method rubygems/rubygems@21dcdd2dc5

For the purpose of this class, we need to make sure the return object by `Gem::UriParser.parse_uri` method will have the following method: - user - user= - password - password= So we can remove the the `uri` dependency and just look for the methods to exist. rubygems/rubygems@241e093597

rubygems/rubygems@3a8486794e

…usly by mistake rubygems/rubygems@ffb480ca7a

rubygems/rubygems@c3bb52eb5c

…e_uri` rubygems/rubygems@25c99d7f9d

rubygems/rubygems@30f5b3c027

We will be passing string to this class so there is no need to be defensive about it. rubygems/rubygems@30bd52a977

ref: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#onpushpull_requestbranchestags Running jobs with only branch name, without `branches:`, CI fails rubygems/rubygems@fcec167d61

rubygems/rubygems@2ee3e78a7a

…g it rubygems/rubygems@95326f827c

…to a `Gem::Uri` class The new class is a wrapper on top of an URI. And then, when you want credentials redacted, you call `#redacted` that returns a copy of itself, but with credentials redacted. rubygems/rubygems@9581c2740a

Same reason as in the previous commit. rubygems/rubygems@f00a6c8516

rubygems/rubygems@9978b787a0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update rubygems and bundler with master branch #4789

Update rubygems and bundler with master branch #4789

Commits on Aug 31, 2021