Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace RB_TYPE_P macro to FIXNUM_P macro #4816

Merged
merged 1 commit into from
Sep 12, 2021
Merged

Replace RB_TYPE_P macro to FIXNUM_P macro #4816

merged 1 commit into from
Sep 12, 2021

Conversation

S-H-GAMELINKS
Copy link
Contributor

Replace RB_TYPE_P macro to FIXNUM_P macro like these code.

RB_TYPE_P(y, T_FIXNUM)

@nobu
Copy link
Member

nobu commented Sep 11, 2021

Could you resolve the conflicts?
And RB_INTEGER_TYPE_P would be usable for these combinations.

@S-H-GAMELINKS
Copy link
Contributor Author

@nobu
Thanks your comments. I'll resolve it.

And, added RB_INTEGER_TYPE_P macro like this.

RB_INTEGER_TYPE_P(y) && FIXNUM_P(y)

@nobu
Copy link
Member

nobu commented Sep 11, 2021

As RB_INTEGER_TYPE_P includes FIXNUM_P, it equals mere FIXNUM_P(y).

@nobu
Copy link
Member

nobu commented Sep 11, 2021

I mean (RB_TYPE_P(y, T_FIXNUM) || RB_TYPE_P(y, T_BIGNUM)) -> (RB_INTEGER_TYPE_P(y)).

@S-H-GAMELINKS
Copy link
Contributor Author

@nobu
Thanks your reply. The conflicts has been resolved and Using RB_INTEGER_TYPE_P macro.

@nobu nobu merged commit af5826a into ruby:master Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@S-H-GAMELINKS @nobu