Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and Using RBOOL macro #4837

Merged
merged 3 commits into from
Sep 14, 2021
Merged

Refactor and Using RBOOL macro #4837

merged 3 commits into from
Sep 14, 2021

Conversation

S-H-GAMELINKS
Copy link
Contributor

@S-H-GAMELINKS S-H-GAMELINKS commented Sep 14, 2021 •
edited

Refactor some function return vaalue and Using RBOOL macro.

nobu
nobu approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@nobu nobu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation in numeric.c is off.

error.c Outdated
if (!rb_equal(exc_backtrace(exc), backtrace))
return Qfalse;
return Qtrue;
return RBOOL(rb_equal(exc_backtrace(exc), backtrace));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return RBOOL(rb_equal(exc_backtrace(exc), backtrace));
return rb_equal(exc_backtrace(exc), backtrace);

rb_equal returns Qtrue or Qfalse.

@S-H-GAMELINKS
Copy link
Contributor Author

@nobu
Thanks for your comments.

Removed RBOOL macro and using rb_equal function return value.
And, fixed indent in fix_gt, fix_ge, fix_lt and fix_le in numeric.c

@nobu nobu merged commit b8c3a84 into ruby:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nobu nobu nobu approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@S-H-GAMELINKS @nobu