Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mutex_mark is NULL, so we don't have any references to mark. This means we should safely be able to mark Mutex as
WB_PROTECTED
without changing anything else.Large Rails apps can have a lot of Mutexes which stick around for the entire process due to using
Concurrent::Map
fromconcurrent-ruby
. Setting them asWB_PROTECTED
means we don't need to do extra work re-checking them every minor GC.Benchmark
Before
After