Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor sym_step_i function #4923

Merged
merged 2 commits into from
Oct 10, 2021
Merged

Refactor sym_step_i function #4923

merged 2 commits into from
Oct 10, 2021

Conversation

S-H-GAMELINKS
Copy link
Contributor

Using step_i function in sym_step_i function, because to more simply code.

@nobu
Copy link
Member

nobu commented Oct 2, 2021

This seems that symbol.step(n) will generate more unused symbol objects.
What about extracting the former half of these functions?

@nobu
Copy link
Member

nobu commented Oct 2, 2021

I mean the rest of rb_yeild lines.

@S-H-GAMELINKS
Copy link
Contributor Author

@nobu
Thanks for your comments.

What about extracting the former half of these functions?
Added step_i_iter function.

@nobu nobu merged commit afb95d1 into ruby:master Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@S-H-GAMELINKS @nobu