Enhanced RDoc for Enumerable#slice_before #4932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyevans
requested changes
Oct 5, 2021
enum.c
Outdated
|
|
||
| * The result enumerator yields the chunked elements as an array. | ||
| * So +each+ method can be called as follows: | ||
| * Returns an Enumerator. |
There was a problem hiding this comment.
I think we can remove this line. It's obvious from the call-seq.
enum.c
Outdated
| * [1, 2, 3, 4, 5] | ||
| * [6, 7, 8, 9, 10, 11, 12, 13, 14, 15] | ||
| * | ||
| * Example with an array and string pattern: |
There was a problem hiding this comment.
I don't think we need 4 examples of pattern argument usage, as they are more of an example of differences in === behavior than slice_before behavior. A single example should suffice, pick your favorite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.