process.c: Add Process._fork #5017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This API is supposed for application monitoring libraries to hook fork event. [Feature #17795]
nobu
reviewed
Oct 25, 2021
...or a platform that has no fork https://github.com/mame/ruby/runs/3992670825?check_suite_focus=true ``` ../src/process.c:8731:54: error: 'rb_proc__fork' undeclared (first use in this function); did you mean 'rb_proc_dup'? 8731 | rb_define_singleton_method(rb_mProcess, "_fork", rb_proc__fork, 0); ```
|
Why not use something like tracepoint? |
byroot
approved these changes
Oct 25, 2021
That would be a lot of overhead for just catching forks. See https://github.com/rails/rails/blob/31ad3f152954142c68c030db596c35e31ca93a76/activesupport/lib/active_support/fork_tracker.rb for instance. |
|
Sorry for the terse reply, I didn't realise there was such discussion behind the issue already. I just spent some time to read it. I'll reply on the RBT issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API is supposed for application monitoring libraries to hook fork
event.
[Feature #17795]