Anonymous lvar #5035
Merged
Anonymous lvar #5035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Could we pull the |
I tested locally they pass. 👍 |
Haven't they been included in dc8d349? |
🤦 yes, yes they did. |
|
So I tried this branch against our app and it crashed inside error_highlight:
|
|
The following is broken though: def foo
end
p RubyVM::AbstractSyntaxTree.of(method(:foo))
def foo(*)
end
p RubyVM::AbstractSyntaxTree.of(method(:foo))
def foo(**)
end
p RubyVM::AbstractSyntaxTree.of(method(:foo))
def foo(*, **)
end
p RubyVM::AbstractSyntaxTree.of(method(:foo))
RubyVM::InstructionSequence.load_from_binary(RubyVM::InstructionSequence.compile_file(__FILE__).to_binary).eval$ ./ruby /tmp/ast.rb
#<RubyVM::AbstractSyntaxTree::Node:SCOPE@1:0-2:3>
#<RubyVM::AbstractSyntaxTree::Node:SCOPE@5:0-6:3>
#<RubyVM::AbstractSyntaxTree::Node:SCOPE@9:0-10:3>
#<RubyVM::AbstractSyntaxTree::Node:SCOPE@13:0-14:3>
<internal:ast>:67:in `of': wrong argument type nil (expected Array) (TypeError)
from /tmp/ast.rb:3:in `<main>'
from /tmp/ast.rb:17:in `eval'
from /tmp/ast.rb:17:in `<main>' |
|
As it crashed also on the current master, seems a different bug. |
|
The explanation in the commit log feels inaccurate or insufficient now. |
```ruby
def foo(*); ->{ super }; end
```
This code makes anonymous parameters which is not registered as an
ID. The problem is that when Ractors try to scan `getlocal`
instructions, it puts the Symbol corresponding to the parameter
in to a hash. Since it is not registered, we end up with a
strange exception. This commit wraps the unregistered ID in an
internal ID so that we get the same exception for `...` as `*`.
Co-Authored-By: Aaron Patterson <tenderlove@ruby-lang.org>
Co-Authored-By: John Hawthorn <john@hawthorn.email>
|
Just a quick note: this change seems not to work correctly on Solaris. http://rubyci.s3.amazonaws.com/solaris10-gcc/ruby-master/log/20211107T120003Z.fail.html.gz |
|
debian-i386 also failed with the same errors. Maybe this change does not work on 32 bit machines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.