Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced RDoc for Float #5153

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Enhanced RDoc for Float #5153

merged 2 commits into from
Nov 22, 2021

Conversation

BurdetteLamar
Copy link
Member

Treats:

  • #>
  • #>=
  • #<
  • #<=
  • #eql?
  • #nan?
  • #infinite?
  • #finite?

@BurdetteLamar BurdetteLamar added the Documentation Improvements to documentation. label Nov 21, 2021
@BurdetteLamar
Copy link
Member Author

@jeremyevans, the "What's Here" for Integer will follow this PR; then I'll return to the methods in Float.

jeremyevans
jeremyevans requested changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@jeremyevans jeremyevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, though I would drop some of the new paragraphs, see inline.

numeric.c Outdated Show resolved Hide resolved
@BurdetteLamar
Copy link
Member Author

@jeremyevans, ready to go?

jeremyevans
jeremyevans approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@jeremyevans jeremyevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@BurdetteLamar BurdetteLamar merged commit e42f994 into ruby:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyevans jeremyevans jeremyevans approved these changes

Assignees
No one assigned
Labels
Documentation Improvements to documentation.
Milestone
No milestone
2 participants
@BurdetteLamar @jeremyevans