Add documentation in lib/shell.rb #516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch by Giorgos Tsiftsis [Bug ruby#9429] [ci skip] git-svn-id: svn+ssh://svn.ruby-lang.org/ruby/trunk@44696 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
git-svn-id: svn+ssh://svn.ruby-lang.org/ruby/trunk@44697 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
* test/ruby/test_process.rb (test_clock_getres): ignore if clock_getres is no supported, e.g., on old Linux. git-svn-id: svn+ssh://svn.ruby-lang.org/ruby/trunk@44698 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
* vm_backtrace.c (rb_backtrace_print_as_bugreport): initialize header-printed flag. git-svn-id: svn+ssh://svn.ruby-lang.org/ruby/trunk@44699 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
* class.c (rb_obj_methods): simplify without jump. git-svn-id: svn+ssh://svn.ruby-lang.org/ruby/trunk@44700 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
git-svn-id: svn+ssh://svn.ruby-lang.org/ruby/trunk@44701 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
* class.c (rb_extract_keywords): treat nil keyword_hash same as 0, for the case rb_scan_args returns nil if no keyword hash. git-svn-id: svn+ssh://svn.ruby-lang.org/ruby/trunk@44702 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
* insns.def (opt_mod, opt_aset_with, opt_aref_with, opt_regexpmatch1): adjust style, do not cuddle else up. git-svn-id: svn+ssh://svn.ruby-lang.org/ruby/trunk@44703 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
* compile.c (iseq_compile_each): fstring is need marking. git-svn-id: svn+ssh://svn.ruby-lang.org/ruby/trunk@44704 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
* compile.c (iseq_compile_each): result of assignment should be its rhs instead of returned value from a method. [ruby-core:60071] [Bug ruby#9448] git-svn-id: svn+ssh://svn.ruby-lang.org/ruby/trunk@44705 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
* process.c (send_child_error): retry write on EINTR to fix occasional Errno::EINTR from Process.spawn. * process.c (recv_child_error): retry read on EINTR to fix occasional Errno::EINTR from Process.spawn. git-svn-id: svn+ssh://svn.ruby-lang.org/ruby/trunk@44706 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
…ists. git-svn-id: svn+ssh://svn.ruby-lang.org/ruby/trunk@44707 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
|
@reprah Could you rebase this? Something messed up on our svn+git sync. |
|
@zzak Sure. So on my feature branch and push that to my fork? |
|
@reprah That should work, alternatively I can just look at reprah/ruby@a83f1cf but if you plan to make any more commits you should give it a rebase. |
|
@zzak sorry for the delay in getting back to you on this! There are issues with rebasing my documentation onto the current trunk. I get several merge conflicts when running `git pull upstream trunk' to update my fork's trunk and can't proceed to rebasing... if you can use the file you mentioned in your comment above, that'd be great. Sorry for the inconvenience and thanks for your hard work. |
|
@reprah No worries, I will try to merge this soon. I can merge it easily enough by hand :) |
|
merged by r45881. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds descriptions/examples for three class-level methods of Shell:
If you, @zzak, have time to review/suggest changes that's always appreciated. Thanks!