Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YJIT: Freeze string literals in yjit.rb #5246

Merged
merged 1 commit into from
Dec 11, 2021
Merged

YJIT: Freeze string literals in yjit.rb #5246

merged 1 commit into from
Dec 11, 2021

Conversation

XrXr
Copy link
Member

@XrXr XrXr commented Dec 11, 2021 •
edited

Also, add a newline before the module doc string so RDoc can find it.
While we are at it, edit for clarity.

The pragma should have no effect since string literals should already be frozen as of c10d508. Let's run CI just to be sure.

@XrXr
YJIT: Freeze string literals in yjit.rb
14c1c30 
Also, add a newline before the module doc string so RDoc can find it.
While we are at it, edit for clarity.
@XrXr
Copy link
Member Author

XrXr commented Dec 11, 2021 •
edited

@zverok Thank you for taking the initiative to improve docs by opening [Misc #18404]. I noticed the lack of docs for ::RubyVM::YJIT thanks to your ticket.

@XrXr XrXr merged commit 3518b00 into ruby:master Dec 11, 2021
@XrXr XrXr deleted the yjit-rdoc branch December 11, 2021 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximecb maximecb Awaiting requested review from maximecb

@tenderlove tenderlove Awaiting requested review from tenderlove

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
1 participant
@XrXr