Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced RDoc for IO.popen #5430

Merged
merged 3 commits into from
Jan 12, 2022
Merged

Enhanced RDoc for IO.popen #5430

merged 3 commits into from
Jan 12, 2022

Conversation

BurdetteLamar
Copy link
Member

This is tough.

@BurdetteLamar BurdetteLamar added the Documentation Improvements to documentation. label Jan 11, 2022
jeremyevans
jeremyevans requested changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@jeremyevans jeremyevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, please see requested changes.

io.c Outdated Show resolved Hide resolved
io.c Outdated Show resolved Hide resolved
io.c Show resolved Hide resolved
io.c Show resolved Hide resolved
jeremyevans
jeremyevans approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@jeremyevans jeremyevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@BurdetteLamar BurdetteLamar merged commit faf79d3 into ruby:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyevans jeremyevans jeremyevans approved these changes

Assignees
No one assigned
Labels
Documentation Improvements to documentation.
Milestone
No milestone
2 participants
@BurdetteLamar @jeremyevans