Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Enhanced RDoc for io.c #5527

Merged
merged 7 commits into from
Feb 4, 2022
Merged

[DOC] Enhanced RDoc for io.c #5527

merged 7 commits into from
Feb 4, 2022

Conversation

BurdetteLamar
Copy link
Member

Treats:

  • IO.read (corrects arguments error)
  • IO.binread (abbreviated to be like IO.binwrite).
  • IO.write
  • IO.binwrite
  • IO.copystream
  • IO#external_encoding
  • IO#internal_encoding
  • IO#set_encoding

@BurdetteLamar BurdetteLamar added the Documentation Improvements to documentation. label Feb 4, 2022
peterzhu2118
peterzhu2118 reviewed Feb 4, 2022
View reviewed changes
io.c Outdated Show resolved Hide resolved
io.c Show resolved Hide resolved
io.c Outdated Show resolved Hide resolved
io.c Outdated Show resolved Hide resolved
io.c Outdated Show resolved Hide resolved
io.c Outdated Show resolved Hide resolved
io.c Outdated Show resolved Hide resolved
io.c Outdated Show resolved Hide resolved
io.c Outdated Show resolved Hide resolved
io.c Outdated Show resolved Hide resolved
@BurdetteLamar BurdetteLamar requested review from peterzhu2118 and removed request for zverok February 4, 2022 20:09
peterzhu2118
peterzhu2118 reviewed Feb 4, 2022
View reviewed changes
io.c Outdated Show resolved Hide resolved
io.c Show resolved Hide resolved
peterzhu2118
peterzhu2118 reviewed Feb 4, 2022
View reviewed changes
Copy link
Member

@peterzhu2118 peterzhu2118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, otherwise looks great! Thank you!

io.c Outdated Show resolved Hide resolved
io.c Outdated Show resolved Hide resolved
peterzhu2118
peterzhu2118 approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@peterzhu2118 peterzhu2118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for addressing all my comments!

@BurdetteLamar
Copy link
Member Author

Thanks, @peterzhu2118 for your careful review.

@BurdetteLamar BurdetteLamar merged commit 06a28ec into ruby:master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterzhu2118 peterzhu2118 peterzhu2118 approved these changes

Assignees
No one assigned
Labels
Documentation Improvements to documentation.
Milestone
No milestone
2 participants
@BurdetteLamar @peterzhu2118