Rename ASCII-8BIT encoding to BINARY
#5571
Open
+169
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
encoding-binary-rename
branch
7 times, most recently
from
9a33107
to
647d107
Compare
This was referenced Feb 18, 2022
casperisfine
force-pushed
the
encoding-binary-rename
branch
from
647d107
to
b83326f
Compare
kou
reviewed
Feb 19, 2022
| @@ -160,7 +160,7 @@ static VALUE transcode_io(VALUE src, int * parser_encoding) | |||
| return src; | |||
| } | |||
|
|
|||
| /* Just guess on ASCII-8BIT */ | |||
| /* Just guess on BINARY */ | |||
| if (io_external_enc_index == rb_ascii8bit_encindex()) { | |||
There was a problem hiding this comment.
Does this proposal keep ascii8bit name in C API?
There was a problem hiding this comment.
Yes, we could alias it as well, but since C-extensions are usually written by more advanced users it's not that useful I think.
There was a problem hiding this comment.
I would advocate for consistency across C and ruby
casperisfine
force-pushed
the
encoding-binary-rename
branch
from
fbd8af6
to
2b4047a
Compare
kou
pushed a commit
to test-unit/test-unit
that referenced
this pull request
Feb 21, 2022
Ref: https://bugs.ruby-lang.org/issues/18576 Ref: ruby/ruby#5571 I'd like to rename `ASCII-8BIT` into `BINARY` for Ruby 3.2, and since test-unit's test suite is integrated into Ruby it breaks the build. Co-authored-by: Jean Boussier <jean.boussier@gmail.com>
[Feature #18576] `ASCII-8BIT` is now an alias to `BINARY`
casperisfine
force-pushed
the
encoding-binary-rename
branch
from
2b4047a
to
0135849
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Feature #18576]
Ref: https://bugs.ruby-lang.org/issues/18576
ASCII-8BITis now an alias toBINARY