[DOC] Enhanced RDoc for String #5635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Second commit adds #squeeze and #squeeze!, which I had not realized use character selectors. |
peterzhu2118
reviewed
Mar 9, 2022
peterzhu2118
reviewed
Mar 9, 2022
peterzhu2118
reviewed
Mar 9, 2022
Co-authored-by: Peter Zhu <peter@peterzhu.ca>
Co-authored-by: Peter Zhu <peter@peterzhu.ca>
peterzhu2118
reviewed
Mar 9, 2022
Comment on lines
8
to
+16
| - String#tr(selector, replacements): returns a new string. | ||
| - String#tr!(selector, replacements): returns +self+. | ||
| - String#tr!(selector, replacements): returns +self+ or +nil+. | ||
| - String#tr_s(selector, replacements): returns a new string. | ||
| - String#tr_s!(selector, replacements): returns +self+. | ||
| - String#tr_s!(selector, replacements): returns +self+ or +nil+. | ||
| - String#count(*selectors): returns the count of the specified characters. | ||
| - String#delete(*selectors): returns a new string. | ||
| - String#delete!(*selectors): returns +self+. | ||
| - String#count(*selectors): counts specified characters. | ||
| - String#delete!(*selectors): returns +self+ or +nil+. | ||
| - String#squeeze(*selectors): returns a new string. | ||
| - String#squeeze!(*selectors): returns +self+ or +nil+. |
There was a problem hiding this comment.
Should these be in alphabetical order?
There was a problem hiding this comment.
I've grouped those with argument replacements first, then those without.
Co-authored-by: Peter Zhu <peter@peterzhu.ca>
peterzhu2118
approved these changes
Mar 10, 2022
matzbot
pushed a commit
that referenced
this pull request
Jun 26, 2022
… --update While generate_index did clean up temporary directory, when running with --update flag, that did not happen and the temporary directory was left behind. This commit fixes that and modifies tests in order to make sure this is not reintroduced later on. Fixes #5635. rubygems/rubygems@9fa34dc329
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treats:
Adds section "Multiple Character Selectors" to doc/character_selectors.rdoc.