Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redo finer-grained inline constant cache invalidation #5716

Merged
merged 2 commits into from Apr 1, 2022
Merged

Redo finer-grained inline constant cache invalidation #5716

merged 2 commits into from Apr 1, 2022

Commits on Apr 1, 2022

  1. Fix up global name references in misc/lldb_disasm.py 

    Some of the symbols had changed names and the script was no longer
finding them.
    @tenderlove @kddnewton
    tenderlove authored and kddnewton committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    50fb392 View commit details
    Browse the repository at this point in the history

  2. Finer-grained constant cache invalidation (take 2) 

    This commit reintroduces finer-grained constant cache invalidation.
After 8008fb7 got merged, it was causing issues on token-threaded
builds (such as on Windows).

The issue was that when you're iterating through instruction sequences
and using the translator functions to get back the instruction structs,
you're either using `rb_vm_insn_null_translator` or
`rb_vm_insn_addr2insn2` depending if it's a direct-threading build.
`rb_vm_insn_addr2insn2` does some normalization to always return to
you the non-trace version of whatever instruction you're looking at.
`rb_vm_insn_null_translator` does not do that normalization.

This means that when you're looping through the instructions if you're
trying to do an opcode comparison, it can change depending on the type
of threading that you're using. This can be very confusing. So, this
commit creates a new translator function
`rb_vm_insn_normalizing_translator` to always return the non-trace
version so that opcode comparisons don't have to worry about different
configurations.

[Feature #18589]
    @kddnewton
    kddnewton committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    5b223bf View commit details
    Browse the repository at this point in the history