thread_pthread.c: call SUSPENDED event when entering native_sleep #6101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great, thanks! :D |
[Bug #18900] Thread#join and a few other codepaths are using native sleep as a way to suspend the current thread. So we should call the relevant hook when this happen, otherwise some thread may transition directly from `RESUMED` to `READY`.
casperisfine
force-pushed
the
gvl-instrumentation-thread-join
branch
from
eda6c7c
to
a24da89
Compare
|
🤦 I had two tabs open and merged the wrong PR. @ko1 if this fix doesn't seem correct to you let me know and I'll revert. |
froydnj
added a commit
to sorbet/sorbet
that referenced
this pull request
Feb 13, 2024
froydnj
added a commit
to sorbet/sorbet
that referenced
this pull request
Feb 13, 2024
froydnj
added a commit
to sorbet/sorbet
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Bug #18900]
Ref: https://bugs.ruby-lang.org/issues/18900
Thread#join and a few other codepaths are using native sleep as a way to suspend the current thread. So we should call the relevant hook when this happen, otherwise some thread may transition directly from
RESUMEDtoREADY.cc @ivoanjo